certainly makes sense to me. thanks, andrej
On Dec 12, 2007, at 12:50 PM, Ben Webb wrote:
It seemed sensible to me to come up with a default IMP code review
policy. Please take a look over it and if you have any issues with it,
think it needs to be clarified some more, etc., follow up to the list:
Text from that URL:
To ensure code quality, additions to the IMP kernel should be reviewed
by the other developers. In general, this means posting a patch with
some explanation of the changes (e.g. suitable for the source control
logs) to the <> mailing list. This is mandatory for
* Change the API (e.g. remove or rename existing methods or classes,
change the arguments taken by existing methods, change the behavior of
existing methods, change the return values or thrown exceptions of
* Remove or modify existing test cases.
For more minor changes, such as adding new tests, methods and/or
(which may change the ABI but not the API), documentation updates,
review is not required but is recommended.
Patches should contain a related set of changes. For example, a patch
which adds a new method foo, a new testcase for foo, and some
documentation for the SpecialVector class, should be split into two
patches: one for the foo method and test, and the other for the
New code in patches should also adhere to the coding style guidelines.
Rationale: Other developers may have external applications and their
in-progress work which may be adversely affected by your changes.
may also be disagreement about a change, so discussing it on the
list first assures that a consensus is first reached, rather than
developers later reverting the change. It is much easier to review a
patch if it is small and contains only relevant changes, and in
it can generally be applied to source control virtually unchanged if
Andrej Sali, Ph.D.
Professor and Vice Chair, Department of Biopharmaceutical Sciences
Department of Pharmaceutical Chemistry
California Institute for Quantitative Biosciences
University of California at San Francisco
UCSF MC 2552
Byers Hall Room 503B
1700 4th Street
San Francisco, CA 94158-2330, USA
Tel +1 (415) 514-4227; Fax +1 (415) 514-4231
Assistant, Ms. Karin Asensio, Tel +1 (415)514-4228; Lab +1 (415)
514-4232, 4233, 4258