Exactly :) We can fix known failed tests in future minor or major releases, but I think the users should get a failure only if the installation itself is bad or if they themselves broke something.
Barak


On Mon, Oct 21, 2013 at 11:57 AM, Dina Schneidman <duhovka@gmail.com> wrote:
we can simply disable all the failing tests for the release to get a clean ctest run :)


On Mon, Oct 21, 2013 at 11:51 AM, Barak Raveh <barak.raveh@gmail.com> wrote:
If they just run "ctest" right after the installation (which is a very good idea), I assume the SAXS tests will run by default, and they will get a lot of failures and be confused. Of course if they can be easily fixed that's also a good solution :) But otherwise, it is nice if after you download the release and run cmake, you will get a completely clean result, assuming that all went well with the installation.


On Mon, Oct 21, 2013 at 11:21 AM, Ben Webb <ben@salilab.org> wrote:
On 10/21/13 11:16 AM, Barak Raveh wrote:
perhaps remove those SAXS failed tests from the release branch? It is
nice if users get a fail free release (so they can know if they have
real installation problems)

I don't see what that buys you - the non-working code is still there. If someone manages to get as far as running the tests while still having "real installation problems" most likely all of them will fail anyway - that should be obvious.


        Ben
--
ben@salilab.org                      http://salilab.org/~ben/
"It is a capital mistake to theorize before one has data."
        - Sir Arthur Conan Doyle
_______________________________________________
IMP-dev mailing list
IMP-dev@salilab.org
https://salilab.org/mailman/listinfo/imp-dev



--
Barak

_______________________________________________
IMP-dev mailing list
IMP-dev@salilab.org
https://salilab.org/mailman/listinfo/imp-dev



_______________________________________________
IMP-dev mailing list
IMP-dev@salilab.org
https://salilab.org/mailman/listinfo/imp-dev




--
Barak