I think we should try the more stable implementation. if it works, we can keep this functionality.
On Mon, Apr 29, 2013 at 10:30 AM, Barak Raveh barak.raveh@gmail.com wrote:
> So what's the final verdict on this? > > Daniel, I invalidated the tests in algebra, but that's not necessary for > functions we're gonna remove - should we remove the two tests that fail ("Check > Euler ZYZ conversionshttps://salilab.org/internal/imp/nightly/results/?test=1490&plat=1" > and "test conversion of euler angleshttps://salilab.org/internal/imp/nightly/results/?test=1532&plat=1") > or do we need to keep part of them? > > > On Fri, Apr 26, 2013 at 8:55 AM, Javier Velazquez-Muriel <javi@salilab.org > > wrote: > >> em2d/internal contains more stable versions. >> >> >> On Wed Apr 24 14:56:45 2013, Barak.raveh wrote: >> >>> Does anyone use Euler angles? The related functions don't work too >>> well (numerical instability) so let us know if you need them / feel >>> like fixing them / ok with getting rid of them / marking then as >>> dangerous >>> >>> On Apr 24, 2013, at 2:53 PM, drussel <notifications@github.com >>> <mailto:notifications@github.**com notifications@github.com>> wrote: >>> >>> Should probably just remove the functions. They are numerically >>>> unstable and no one has any interest in fixing them. >>>> >>>> — >>>> Reply to this email directly or view it on GitHub >>>> <https://github.com/salilab/**imp/issues/303#issuecomment-**16970820https://github.com/salilab/imp/issues/303#issuecomment-16970820 >>>> >. >>>> >>>> >>> >>> ______________________________**_________________ >>> IMP-dev mailing list >>> IMP-dev@salilab.org >>> https://salilab.org/mailman/**listinfo/imp-devhttps://salilab.org/mailman/listinfo/imp-dev >>> >> ______________________________**_________________ >> IMP-dev mailing list >> IMP-dev@salilab.org >> https://salilab.org/mailman/**listinfo/imp-devhttps://salilab.org/mailman/listinfo/imp-dev >> > > > > -- > Barak > > _______________________________________________ > IMP-dev mailing list > IMP-dev@salilab.org > https://salilab.org/mailman/listinfo/imp-dev > >