Since we are doing the patch game, here are some trivial ones: Add addition and multiplication by a scalar to vector3D (python support needs to be added separately).
Just throw an exception on a bad cast (no error message) in the decorator. Currently catching an exception is the only way to check if a particle has the required fields or not. We may want to add a cleaner mechanism.
Make sure that bonds connect two different particles.
Daniel Russel wrote: ... > Make sure that bonds connect two different particles.
With that patch applied, 'scons examples' fails with:
ERROR: The endpoints of a bond must be disjoint Traceback (most recent call last): File "chain.py", line 29, in <module> b= IMP.custom_bond(bp, bpr, 1.5*radius, 10) ValueError: The endpoints must be disjoint examples FAILED
Ben
Its a good check to add, already found a bug :-)
Here is a patch for chain.py:
On May 6, 2008, at 5:50 PM, Ben Webb wrote:
> Daniel Russel wrote: > ... >> Make sure that bonds connect two different particles. > > With that patch applied, 'scons examples' fails with: > > ERROR: The endpoints of a bond must be disjoint > Traceback (most recent call last): > File "chain.py", line 29, in <module> > b= IMP.custom_bond(bp, bpr, 1.5*radius, 10) > ValueError: The endpoints must be disjoint > examples FAILED > > Ben > -- > ben@salilab.org http://salilab.org/~ben/ > "It is a capital mistake to theorize before one has data." > - Sir Arthur Conan Doyle > _______________________________________________ > IMP-dev mailing list > IMP-dev@salilab.org > https://salilab.org/mailman/listinfo/imp-dev
participants (2)
-
Ben Webb -
Daniel Russel