I propose we change IMP.vectori and IMP.vectorf to IMP.Ints and IMP.Floats to be consistent. Any objections?
Daniel Russel wrote: > I propose we change IMP.vectori and IMP.vectorf to IMP.Ints and > IMP.Floats to be consistent. Any objections?
Sounds good to me. Anything is better than vectori and vectorf, at any rate (I suspect Bret used those because they're the example in the SWIG manual for %template).
Ben
it will probably break the impEM test cases. but if you change them accordingly, i do not object.
f
Ben Webb wrote: > Daniel Russel wrote: > >> I propose we change IMP.vectori and IMP.vectorf to IMP.Ints and >> IMP.Floats to be consistent. Any objections? >> > > Sounds good to me. Anything is better than vectori and vectorf, at any > rate (I suspect Bret used those because they're the example in the SWIG > manual for %template). > > Ben >
Friedrich Foerster wrote: > it will probably break the impEM test cases. but if you change them > accordingly, i do not object.
Daniel's patch already updated the impEM test cases (largely because I require that all tests pass for commits). This is one advantage of putting your interface into SVN and writing test cases. ;)
Ben
-
Ben Webb -
Daniel Russel -
Friedrich Foerster