This patch cleans up the code for the attribute arrays in decorators. In terms of API changes it adds a method to get the ith residue from a protein or chain or nucleotide. It also now enforces the create/cast distinction with bonds, bonded and hierarchy nodes (previously any node was a hierarchy node without having create cast on it).
Daniel Russel wrote: > This patch cleans up the code for the attribute arrays in decorators. In > terms of API changes it adds a method to get the ith residue from a > protein or chain or nucleotide. It also now enforces the create/cast > distinction with bonds, bonded and hierarchy nodes (previously any node > was a hierarchy node without having create cast on it).
Committed as r591, but this breaks the example chain.py. Can you fix that, please?
cd /Users/ben/imp/kernel/doc/examples && /Users/ben/imp/bin/imppy.sh python chain.py > /dev/null Traceback (most recent call last): File "chain.py", line 29, in <module> bpr= IMP.BondedDecorator.cast(chain[i-1]) ValueError: Particle missing required attribues in cast examples FAILED
Ben
Sorry, I forgot the patch on that.
On Jun 11, 2008, at 1:57 PM, Ben Webb wrote:
> Daniel Russel wrote: >> This patch cleans up the code for the attribute arrays in >> decorators. In >> terms of API changes it adds a method to get the ith residue from a >> protein or chain or nucleotide. It also now enforces the create/cast >> distinction with bonds, bonded and hierarchy nodes (previously any >> node >> was a hierarchy node without having create cast on it). > > Committed as r591, but this breaks the example chain.py. Can you fix > that, please? > > cd /Users/ben/imp/kernel/doc/examples && /Users/ben/imp/bin/imppy.sh > python chain.py > /dev/null > Traceback (most recent call last): > File "chain.py", line 29, in <module> > bpr= IMP.BondedDecorator.cast(chain[i-1]) > ValueError: Particle missing required attribues in cast > examples FAILED > > Ben > -- > ben@salilab.org http://salilab.org/~ben/ > "It is a capital mistake to theorize before one has data." > - Sir Arthur Conan Doyle > _______________________________________________ > IMP-dev mailing list > IMP-dev@salilab.org > https://salilab.org/mailman/listinfo/imp-dev
Daniel Russel wrote: > This patch cleans up the code for the attribute arrays in decorators.
This patch breaks the build on several platforms. It won't compile with MSVC, and the unit tests fail on a couple of other platforms. See https://salilab.org/internal/imp/tests.html
Ben
Looks like a key line got skipped somewhere in the submit process.
Here is yesterdays' patch including an added call in decorators/macros.h
The patch also adds IMPDLLEXPORT to the class VC can't find in units.h.
On Jun 13, 2008, at 11:12 AM, Ben Webb wrote:
> Daniel Russel wrote: >> This patch cleans up the code for the attribute arrays in decorators. > > This patch breaks the build on several platforms. It won't compile > with > MSVC, and the unit tests fail on a couple of other platforms. See > https://salilab.org/internal/imp/tests.html > > Ben > -- > ben@salilab.org http://salilab.org/~ben/ > "It is a capital mistake to theorize before one has data." > - Sir Arthur Conan Doyle > _______________________________________________ > IMP-dev mailing list > IMP-dev@salilab.org > https://salilab.org/mailman/listinfo/imp-dev
Fixed line lengths in the previous patch
On Jun 13, 2008, at 11:34 AM, Daniel Russel wrote:
> Looks like a key line got skipped somewhere in the submit process. > > Here is yesterdays' patch including an added call in decorators/ > macros.h > > The patch also adds IMPDLLEXPORT to the class VC can't find in > units.h. > > <cumulative> > > > On Jun 13, 2008, at 11:12 AM, Ben Webb wrote: > >> Daniel Russel wrote: >>> This patch cleans up the code for the attribute arrays in >>> decorators. >> >> This patch breaks the build on several platforms. It won't compile >> with >> MSVC, and the unit tests fail on a couple of other platforms. See >> https://salilab.org/internal/imp/tests.html >> >> Ben >> -- >> ben@salilab.org http://salilab.org/~ben/ >> "It is a capital mistake to theorize before one has data." >> - Sir Arthur Conan Doyle >> _______________________________________________ >> IMP-dev mailing list >> IMP-dev@salilab.org >> https://salilab.org/mailman/listinfo/imp-dev > > _______________________________________________ > IMP-dev mailing list > IMP-dev@salilab.org > https://salilab.org/mailman/listinfo/imp-dev
-
Ben Webb -
Daniel Russel -
Daniel Russel