Two suggestions: First, replace last_modified_by with get_author and version with get_version. Second, define a standard IMP version number and use it for all objects in the IMP kernel. And have a standard author list (or just say "IMP core developers" and give some general imp email address).
We never really bother to update those fields as it is, and for most people the IMP version will be what matters (and for us, the SVN version gives us the information we need).
Daniel Russel wrote: > First, replace last_modified_by with get_author and version with > get_version. > Second, define a standard IMP version number and use it for all > objects in the IMP kernel. And have a standard author list (or just > say "IMP core developers" and give some general imp email address).
How about we go one step further and do something like (pseudo code)
struct VersionInfo { std::vector author, version; }
virtual Restraint::get_version_info { return VersionInfo("IMP core developers", "SVN"); }
That way 1) a module can define a static VersionInfo somewhere (or a get_version_info() function) and all restraints etc. can return the same thing and 2) we reduce the number of virtual methods by one.
Ben
Fine by me.
On Feb 25, 2008, at 7:49 AM, Ben Webb wrote:
> Daniel Russel wrote: >> First, replace last_modified_by with get_author and version with >> get_version. >> Second, define a standard IMP version number and use it for all >> objects in the IMP kernel. And have a standard author list (or just >> say "IMP core developers" and give some general imp email address). > > How about we go one step further and do something like (pseudo code) > > struct VersionInfo { > std::vector author, version; > } > > virtual Restraint::get_version_info { > return VersionInfo("IMP core developers", "SVN"); > } > > That way 1) a module can define a static VersionInfo somewhere (or a > get_version_info() function) and all restraints etc. can return the > same > thing and 2) we reduce the number of virtual methods by one. > > Ben > -- > ben@salilab.org http://salilab.org/~ben/ > "It is a capital mistake to theorize before one has data." > - Sir Arthur Conan Doyle > _______________________________________________ > IMP-dev mailing list > IMP-dev@salilab.org > https://salilab.org/mailman/listinfo/imp-dev
participants (2)
-
Ben Webb -
Daniel Russel