On my machines the test suite complains that a couple of the restraints defined in python are missing the virtual functions for version and last_modified_by. This patch adds those.
On a separate note, it is not clear to me that anyone will ever bother to actually update these fields. Especially since they are defined primarily in the headers and code changes are most likely to occur in the .cpp files. Is it possible to use a SVN hook to update them automatically?
Daniel Russel wrote: > On my machines the test suite complains that a couple of the restraints > defined in python are missing the virtual functions for version and > last_modified_by. This patch adds those.
r345. But I'm curious to know what warnings/errors you're seeing. The test suite runs on all of our build machines without complaining (although I guess it shouldn't, without these implementations). So I wonder what's different about your machines.
> On a separate note, it is not clear to me that anyone will ever bother > to actually update these fields. Especially since they are defined > primarily in the headers and code changes are most likely to occur in > the .cpp files. Is it possible to use a SVN hook to update them > automatically?
For stuff in the kernel, it's probably not worth ever updating them - except perhaps to bump the version number every time we cut an IMP release. I think the value is only for third party extension modules - and they, of course, can update them whenever they choose (or not all, I guess).
Ben
On Jan 29, 2008, at 8:10 PM, Ben Webb wrote: > r345. But I'm curious to know what warnings/errors you're seeing. The > test suite runs on all of our build machines without complaining > (although I guess it shouldn't, without these implementations). So I > wonder what's different about your machines. From flute: Traceback (most recent call last): File "kernel/test/cg_optimizer/test_cg.py", line 37, in test_cg_woods_func self._test_starting_conditions((-3.0, -1.0, -3.0, -1.0)) File "kernel/test/cg_optimizer/test_cg.py", line 56, in _test_starting_conditions e = opt.optimize(100) File "/flute1/home/drussel/src/IMP/kernel/pyext/IMP/__init__.py", line 1960, in optimize def optimize(*args): return _IMP.ConjugateGradients_optimize(*args) RuntimeError: : Swig director pure virtual method called IMP::Restraint::version Swig director method error. Error detected when calling 'Restraint.version' Swig director method error. Error detected when calling 'Restraint.show'
participants (2)
-
Ben Webb -
Daniel Russel