This diff removes CoordinateRestraint and adds SphereRestraint which restraints a point's distance to a fixed point. It also makes the vectori to Int change. The XYZ decorators patch is also attached again as the previous version didn't quite split things right (I had needed to add methods to Particle.h to changed the optimized status of a float).
Daniel Russel wrote: > This diff removes CoordinateRestraint and adds SphereRestraint which
Don't you mean SphericalRestraint?
> restraints a point's distance to a fixed point. It also makes the > vectori to Int change. The XYZ decorators patch is also attached again > as the previous version didn't quite split things right (I had needed to > add methods to Particle.h to changed the optimized status of a float).
Looks more or less OK, although I'm sure it'll break Restrainer. (But that can be fixed at some later point.) But your patch seems to be missing SphericalRestraint.cpp...
Ben
In leu of updating the patch, here is the file.
On Dec 14, 2007, at 3:25 PM, Ben Webb wrote:
> Daniel Russel wrote: >> This diff removes CoordinateRestraint and adds SphereRestraint which > > Don't you mean SphericalRestraint? > >> restraints a point's distance to a fixed point. It also makes the >> vectori to Int change. The XYZ decorators patch is also attached >> again >> as the previous version didn't quite split things right (I had >> needed to >> add methods to Particle.h to changed the optimized status of a >> float). > > Looks more or less OK, although I'm sure it'll break Restrainer. (But > that can be fixed at some later point.) But your patch seems to be > missing SphericalRestraint.cpp... > > Ben > -- > ben@salilab.org http://salilab.org/~ben/ > "It is a capital mistake to theorize before one has data." > - Sir Arthur Conan Doyle > _______________________________________________ > IMP-dev mailing list > IMP-dev@salilab.org > https://salilab.org/mailman/listinfo/imp-dev
Daniel Russel wrote: > In leu of updating the patch, here is the file.
OK... so now it's complaining about SphericalRestraint.h...
Ben
Daniel Russel wrote: > This diff removes CoordinateRestraint and adds SphereRestraint which > restraints a point's distance to a fixed point. It also makes the > vectori to Int change. The XYZ decorators patch is also attached again > as the previous version didn't quite split things right (I had needed to > add methods to Particle.h to changed the optimized status of a float).
The patch breaks 3 of the unit tests, at least on synth, so I'm not committing it. For reference, attached is the "complete" patch against r639.
Ben
participants (2)
-
Ben Webb -
Daniel Russel